How long

How long does it take to get to 1million gym stats? I've  been playing a while on and off.

There's no definite answer as it depends on a lot of factors such as how you are training, your activity, your property, energy usage in the gym. Just keep spending as much energy in the gym as possible and doing happy jumps if you can afford them.

Depends if you want to p2w or not

Well, you need to read some guides. I see that you're traveling, but also only buying like 10 items a flight. Extremely inefficient. 

You need to rent a Private Island, join a real faction, get some income going, and then do some happy jumps. You can get to 1mil stats extremely fast. 

Read Baldr's Guide: https://www.torn.com/forums.php#/p=threads&f=61&t=16034448&b=0&a=0

Then look up happy jumping: https://www.torn.com/forums.php#/p=threads&f=61&t=16047184

The speed at which you can gain stats is dependent on different factors.  

Your personal play style determines the speed of gains the most.  You personally have to decide how committed you are to the game and what goals mean the most to you.  

Your energy can either be used to build up stats or to attack others.  The more energy you use to build stats the faster you will get to the first million.  

Your energy naturally replenishes so if you consistently show up as soon as you have a full energy bar and train stats with it, you see gains.  However, supplementing your energy by using the daily points refill, taking drugs, buying bonus blocks of particular stocks, and using boosters like cans or eggs will make things go even faster. If you get a particular company job you can add to stats via job points too.  

however, most of those supplemental options cost torn dollars. (Eggs are free but only available during the Easter event and cans can be free if you participate in the right event, but again timing matters) So for most people they have to figure out a money making strategy before starting a supplemental strategy. Attacking is usually your best money making endeavor so if you need money to support you supplemental energy consumption then chances are you have to sacrifice energy to attacking.  It’s a bit of a conundrum. 

Another factor is your faction choice.  Do you choose a smaller faction to build up relationships and all work together to improve it? Do you choose an established faction that already has upgrades that will aid in your training?  It’s all part of your personal play style.  If you value speediness in getting to the first million then joining an established faction is the way to go.  However you need to make sure that established faction has values that align with your goal.  If you choose a warring faction then chances are they have not concentrated on meeting training challenges to upgrade their Steadfast perks.  Also they might expect you to war weekly and that means sats if not training at all while you are stacking energy and then warring with that energy. If you find a faction that focuses on meeting steadfast challenges to upgrade their perks, then you might be able to choose a particular stat to train and benefit from a significant extra percentage increase to every train.  Getting 15% more speed for every train makes a huge difference on how fast you get to the first million.  

Regardless of what choices you make to help improve your pace to get to the first million, there is one very happy result that comes from getting there.  Every million after the first is easier and faster in coming. With every train you do, the amount earned from your train increases incrementally.  That amount is specific to each stat though. So if you focus on just one stat for a while, it becomes sad to start on another because the gains you make seem so much less. I suggest attempting to keep most of your stats fairly even so the temptation to concentrate on one to get bigger gains doesn’t make you all lopsided.  

Good luck!!