Started by Entropi [2486892] on in Bugs & Issues.
Posts archived: 6 / 6 posts (100%) · the total is Torn's reply count + the opening post at the last fetch
Counted by TornLife from the archived posts.
https://www.torn.com/war.php?step=rankreport&rankID=21472
This war report lists me as having made 42 attacks. However, in the attack data returned by the api, I made 43 attacks.
I think the missing one occurred when I defeated somebody but was taken out right after getting to the leave/hospitalize/mug screen so I never clicked the result.
I imagine you are referring to this Attack, the auto-leave can fail to trigger sometimes due to system limitations, so this attack has correctly been not counted towards your war hits. Your target was basically left out of hospital at 1 Life and you gained no respect for the attack. I will ask Mauro to check the API to exclude such hits.
Thanks!
Hey,
Like CJ said, this attack was interrupted, and as such it's not being shown on the ranked war report.
We're showing this attack along with all other attacks in the API, because they were still attacks regardless. Such attacks have an experimental flag "is_interrupted" set to true (this value might not cover all edge cases) in API v2.
Also, 'faction' -> 'attacks' might different from 'torn' -> 'rankedwarreport', because not all attacks were successful.
You can see this attack here:
https://api.torn.com/v2/faction/attacks?key=&from=1737850644&to=1737850644
The 'rankedwarreport' API is showing a correct value for you - you had 42 (successful) attacks:
https://api.torn.com/torn/21472?selections=rankedwarreport&key=
Thanks!
Ah, I grabbed it from api v1 actually. Maybe attacks which auto-leave after interruption are shown as successful in v1 and the `Interrupted` result is only used there when interrupted without the result being changed afterwards by auto-leave?
Hmmm,
I just took another look and it looks like I saw things wrong.
The API/DB shows the result of your attack as "Attacked" and an attack from "LostInSpace" on "Euphe" as "Interrupted".
Your attack should also be "interrupted", but because of what CJ said:
the auto-leave can fail to trigger sometimes due to system limitation
I'm unable to set these as interrupted without processing the whole logs, and that's unfortunately not possible in 'attacks' selections.
However! I started working on the attacklog selection, where you'll be able to view a full logs, so it will be possible to process each log in detail in the future in order to get fully accurate results.
I know that's probably not what you were hoping to hear, but currently there's no better solution to this problem.
I'll leave this bug open, and I'll let you know when that selection becomes available.
Thanks!
Hey Entropi,
As I said previously, I'm unable to mark such attacks as interrupted in the API, however the 'torn' -> 'attacklog' selection is now available:
https://www.torn.com/swagger.php#/Torn/get_torn_attacklog
So any odd attacks can be checked via API as well (and I suspect tools that should help processing attacks will start popping up soon).
Hopefully that helps.
Thanks!