Skip to content
TORNLIFE More

Faction Balance Send Issue

Started by Flid [2594918] on in Bugs & Issues.

16 replies · 293 views · thread synced · 10 days ago · View on torn.com
About this thread

Posts archived: 17 / 17 posts (100%) · the total is Torn's reply count + the opening post at the last fetch

Counted by TornLife from the archived posts.

Archived posts
17
Discussion span
→
People posting
12
Likes on archived posts
46
Posts by staff, officers and moderators
7
Authority score
59 / 100
Historical score
31 / 100
Story score
50 / 100
Engagement score
68 / 100

Most-liked replies

  • Proxima [1879587] Wiki Editor · 17 likes ·
    Cool that important stuff is thoroughly tested for very basic issues before pushing to prod
  • CloudJumper [1636201] · 4 likes ·
    Yevhen is checking this, the fix is almost ready. Thanks!
  • Untouchable [1360035] Committee · 4 likes ·
    Glad it worked out in this instance but this kind of thing shouldn't even be possible from an engineering perspective. For basic/core functionality like this I would expect unit tests to exist that fail a pipeline and don't allow you …
Flid [2594918] · #1

Hello

 

A different faction balance issue, today I accidentally sent our entire vault to a member.

 

Process flow followed:

 

Faction --> Give To User --> Search user --> Select user --> Click $ button to populate what has been the selected members balance --> Give Money

 

The $ button seems to populate the vaults entire funds now, regardless of selected member.

 

Thanks

 

Flid

 

 

Untouchable [1360035] Committee Committee · #7

I don't know if it's relevant, hopefully the person who got the vault balance from OP returns it but in a case like this, would the transaction be reversed since it was due to a bug? 

 

Asking for precedence sake. Obviously it's on the banker to be diligent but a drastic change in functionality like this is bound to cause issues ofc 

bogie [148747] Admin Staff · #9

They got auto jailed and did return it after.

 

I would consider case by case reversals in instances like this where the fault was partly on us but we would review the situation carefully either way as there is still a level of accountability in ignoring the confirmations.

 

Fortunately I didn't have to make that call today. 

Untouchable [1360035] Committee Committee · #11

Glad it worked out in this instance but this kind of thing shouldn't even be possible from an engineering perspective. 

 

For basic/core functionality like this I would expect unit tests to exist that fail a pipeline and don't allow you to merge the code.

 

UAT is clearly insufficient here. 

PMV [1577993] · #12

Fr.

 

How the hell did something like this make it to live? Goddamn, Torn out here following the Microsoft way of QC.